Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct PolygonLayer.useAltRenderer renderer when Polygons have multiple holes #1906

Merged
merged 4 commits into from
Jun 8, 2024

Conversation

JaffaKetchup
Copy link
Member

@JaffaKetchup JaffaKetchup commented Jun 4, 2024

Also added helpful debugging tool to show triangulation output.

Fixes #1899.

…correctly with `useAltRenderer`

Added debug tool `PolygonLayer.debugAltRenderer`
@JaffaKetchup JaffaKetchup requested review from mootw and josxha June 4, 2024 13:55
Copy link
Contributor

@josxha josxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice debug overlay!

One polygon on the polygon page seems odd to me. But it is not caused by this pr because master has the same behavior.

lib/src/layer/polygon_layer/polygon_layer.dart Outdated Show resolved Hide resolved
@JaffaKetchup
Copy link
Member Author

One polygon on the polygon page seems odd to me.

It's designed to show that we don't support self-intersecting Polygons. The earcutting algorithm is an extension of ear-clipping that supports holes, but it still doesn't support self-intersections.

@JaffaKetchup JaffaKetchup merged commit a2bf534 into master Jun 8, 2024
8 checks passed
@JaffaKetchup JaffaKetchup deleted the fix-1899 branch June 8, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Alternative polygon renderer in 7.0 renderers multiple holes incorrectly
2 participants