bugfix: Prevent parent ListView widgets from snatching scrolling gestures #994
Conversation
feature: allow panning on scrollable parents
|
I've just tested this out and it works as advertised without any noticeable issues. However the name of the flag wasn't very intuitive and its implemented as being on by default so it would be a breaking change. I would suggest something like "captureGesturesInScrollview: true" and have it off by default. But im not a package maintainer so just my 2c. Otherwise great work, I was just about to go about implementing it myself for a project due out tomorrow. |
Thank You for your comment. I think It is not a big issue to change that. I can do it. I will wait for review from maintainers and make all the changes along with this if they also suggest any. |
|
Yeah absolutely! Their opinion matters, I really just wanted to let them know its working for me in the wild which gives them some confidence to merge the pr in any form. |
|
@Binabh Can you apply formatting and push the changes? Just run |
|
@kengu done. let me know if anything else is needs to be modified |
|
@kengu fixed the code duplication issue. let me know if anything else required |
This is basically copy of #717 (since the PR creator does not seem intrested in implementing the commented option and PR is now stale). I saw that the PR is not being merged because there is no option to developer if they want previous behavior. I have tried to add a bool in mapoptions to determine the type of behavior in the map.
Let me know if anything else is required. I want this feature to be implemented.
Thank You!