Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove the caching of _cancelledImage #3

Merged
merged 2 commits into from
Oct 11, 2023
Merged

fix: remove the caching of _cancelledImage #3

merged 2 commits into from
Oct 11, 2023

Conversation

TesteurManiak
Copy link
Contributor

This should fix the issue fleaflet/flutter_map#1687 on the flutter_map repo.

@JaffaKetchup
Copy link
Member

If the cache variable will always be null, can't we just remove it altogether and not have a dead/redundant ???

JaffaKetchup
JaffaKetchup approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this.

@JaffaKetchup JaffaKetchup changed the title fix: use the ?? operator instead of ??= fix: remove the caching of _cancelledImage Oct 11, 2023
@JaffaKetchup JaffaKetchup merged commit a315fdc into fleaflet:main Oct 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaffaKetchup JaffaKetchup JaffaKetchup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TesteurManiak @JaffaKetchup