Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow typing performance when approx 45k characters used within editor #244

Closed
nialljawad96 opened this issue Jan 25, 2024 · 2 comments · Fixed by #408
Closed

Slow typing performance when approx 45k characters used within editor #244

nialljawad96 opened this issue Jan 25, 2024 · 2 comments · Fixed by #408
Labels
performance Issue related to performance

Comments

@nialljawad96
Copy link

Steps to Reproduce

  1. Place 45000 characters into editor
  2. Type a sentence
  3. Observe lag and delay

Environment

  • MacOS
  • Flutter 3.16.4
  • Fleather version 1.13.2
@amantoux amantoux added the enhancement New feature or request label Jan 25, 2024
@amantoux
Copy link
Member

amantoux commented Jan 25, 2024

@nialljawad96 thank you for pointing this out
Indeed performance on large pieces of text hasn't been tested yet.

@amantoux amantoux added performance Issue related to performance and removed enhancement New feature or request labels Aug 9, 2024
@Amir-P
Copy link
Member

Amir-P commented Aug 20, 2024

Hi @nialljawad96, we have a PR (#408) that might fix this issue. Would you be able to test it and get back to us? You can use it like following:

dependency_overrides:
  parchment:
    git:
      url: https://github.com/fleather-editor/fleather
      ref: perf/cache_offset_and_length_for_nodes
      path: packages/parchment
  fleather:
    git:
      url: https://github.com/fleather-editor/fleather
      ref: perf/cache_offset_and_length_for_nodes
      path: packages/fleather

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Issue related to performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants