Ionic4 #1
Ionic4 #1
Conversation
| openPage(page) { | ||
| // Reset the content nav to have just this page | ||
| // we wouldn't want the back button to show in this scenario | ||
| this.navController.navigateForward(page.component); |
There was a problem hiding this comment.
If this works for deep-linking like the code below used to, please remove the commented code below.
There was a problem hiding this comment.
I haven't implemented the entity generation part as I have to touch the generator project. I will do it next week I think
|
@mraible I fixed all your requested changes. I think I can merged this PR to open a PR on the ionic-teams starters repo. |
|
@fleboulch I think we should create a new starter in https://github.com/ionic-team/starters/. I believe the contributing document has all the details you might need. I'd call it simply If we create React and Vue versions, those will likely go under As far as where to host the starter, I'm less concerned about where we host it. For consistency and discoverability, it might be good to keep it at oktadeveloper/ionic-jhipster-starter. If you'd like to go that route, please create a PR, or I can add you as a contributor. I can also create a maintenance branch for the current version so the master branch will target v4. |
|
Yes you are right for react and vue versions. But curiously vue directory haven't been created by the ionic-team yet. Ok to host it in your repo. I thought if we merged this PR into master the I will create the PR on |
Fix oktadev#19
Fix jhipster/generator-jhipster-ionic#67
Fix jhipster/generator-jhipster-ionic#58
Fix oktadev#18
Auth supported
App tested
Left TODO
ionic.starter.jsonwith latest hash commit