PATCH: MS Edge cpe translation (#17793)

fleetdm · Mar 22, 2024 · fd71574 · fd71574
1 parent 39f0fd2
commit fd71574
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 4 deletions.
diff --git a/changes/16817-ms-edge-vuln b/changes/16817-ms-edge-vuln
@@ -0,0 +1 @@
+- Fixed issue where microsoft edge was not reporting vulnerabilities
diff --git a/server/vulnerabilities/nvd/README.md b/server/vulnerabilities/nvd/README.md
@@ -10,17 +10,24 @@ To test these changes locally, you can:
 2. host this file on a local web server
 
     ```bash
-    ./tools/file-server 8082 ./server/vulnerabilities/nvd/cpe_translations.json
+    go run ./tools/file-server 8082 ./server/vulnerabilities/nvd
     ```
 
-3. (re)launch your local fleet server with the following `--config`
+3. (re)launch your local fleet server with one of the following
 
+    Config method
     ```yaml
     vulnerabilities:
     cpe_translations_url: "http://localhost:8082/cpe_translations.json"
     ```
 
-4. trigger the vulnerabilities scan
+
+    Environment method
+    ```bash
+    FLEET_VULNERABILITIES_CPE_TRANSLATIONS_URL="http://localhost:8082/cpe_translations.json" ./build/fleet serve --dev --dev_license --logging_debug
+    ```
+
+4. trigger a vulnerabilities scan
 
     ```bash
     fleetctl trigger --name vulnerabilities

diff --git a/server/vulnerabilities/nvd/cpe_test.go b/server/vulnerabilities/nvd/cpe_test.go
@@ -823,7 +823,7 @@ func TestCPEFromSoftwareIntegration(t *testing.T) {
 				Version:          "105.0.1343.50",
 				Vendor:           "Microsoft Corporation",
 				BundleIdentifier: "",
-			}, cpe: "cpe:2.3:a:microsoft:edge:105.0.1343.50:*:*:*:*:windows:*:*",
+			}, cpe: "cpe:2.3:a:microsoft:edge_chromium:105.0.1343.50:*:*:*:*:windows:*:*",
 		},
 		{
 			software: fleet.Software{

diff --git a/server/vulnerabilities/nvd/cpe_translations.json b/server/vulnerabilities/nvd/cpe_translations.json
@@ -139,5 +139,15 @@
       "product": ["pycharm"],
       "vendor": ["jetbrains"]
     }
+  },
+  {
+    "software": {
+      "name": ["Microsoft Edge"],
+      "source": ["programs", "apps"]
+    },
+    "filter": {
+      "product": ["edge_chromium"],
+      "vendor": ["microsoft"]
+    }
   }
 ]