Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached query results on Host details page are missing #18083

Closed
noahtalerman opened this issue Apr 5, 2024 · 5 comments
Closed

Cached query results on Host details page are missing #18083

noahtalerman opened this issue Apr 5, 2024 · 5 comments
Assignees
Labels
bug Something isn't working as documented #g-endpoint-ops Endpoint ops product group P2 Prioritize as urgent :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone

Comments

@noahtalerman
Copy link
Member

Fleet version: Fleet 4.48


💥  Actual behavior

Cached query results show val as the result for all columns:

Screenshot 2024-04-05 at 10 30 46 AM

🧑‍💻  Steps to reproduce

Not sure.

🕯️ More info (optional)

Looks like it's a frontend bug. The GET /hosts/:host_id/queries/:query_id is returned results:

Screenshot 2024-04-05 at 10 32 25 AM

@noahtalerman noahtalerman added bug Something isn't working as documented :reproduce Involves documenting reproduction steps in the issue :incoming New issue in triage process. ~released bug This bug was found in a stable release. and removed :reproduce Involves documenting reproduction steps in the issue labels Apr 5, 2024
@noahtalerman noahtalerman added :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. #g-endpoint-ops Endpoint ops product group labels Apr 5, 2024
@noahtalerman noahtalerman changed the title Cached query results on Host details page are incorrect Cached query results on Host details page are missing Apr 5, 2024
@noahtalerman noahtalerman added P1 Prioritize as critical ~critical bug This is a critical bug and may require a patch release. labels Apr 5, 2024
@sharon-fdm sharon-fdm removed the :incoming New issue in triage process. label Apr 5, 2024
jacobshandling added a commit that referenced this issue Apr 5, 2024
## Addresses #18083 
![Screenshot 2024-04-05 at 9 37
20 AM](https://github.com/fleetdm/fleet/assets/61553566/b683d30c-9af2-4cbb-8cea-b4a6e2422464)



- [x] Changes file added for user-visible changes in `changes/` 
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
@georgekarrv georgekarrv added this to the 4.48.1 milestone Apr 5, 2024
georgekarrv pushed a commit that referenced this issue Apr 5, 2024
## Addresses #18083 
![Screenshot 2024-04-05 at 9 37
20 AM](https://github.com/fleetdm/fleet/assets/61553566/b683d30c-9af2-4cbb-8cea-b4a6e2422464)



- [x] Changes file added for user-visible changes in `changes/` 
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
@lukeheath
Copy link
Member

@noahtalerman @sharon-fdm Reminder that per our high-priority stories and bugs documentation, all P-rated tickets should be assigned to the release ritual DRI (me) first, before being actioned. I then validate they meet the criteria before assigning them to the EM for action. If it's a P0 or P1, DM me on Slack or text me via phone so I can review it immediately.

@lukeheath lukeheath added P2 Prioritize as urgent and removed ~critical bug This is a critical bug and may require a patch release. P1 Prioritize as critical labels Apr 8, 2024
georgekarrv pushed a commit that referenced this issue Apr 8, 2024
## Addresses #18083 
![Screenshot 2024-04-05 at 9 37
20 AM](https://github.com/fleetdm/fleet/assets/61553566/b683d30c-9af2-4cbb-8cea-b4a6e2422464)



- [x] Changes file added for user-visible changes in `changes/` 
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
@fleet-release
Copy link
Contributor

Missing query cache,
Fixed, clarity in data,
Truth within reach now.

@noahtalerman
Copy link
Member Author

Sharon: Following this bug, we found out that no customer is using it. Maybe there is something we could iterate on it to make it more attractive?

Noah: Is that true? I think we don’t know who is using it. We only know that Uber and Fastly aren’t using it (yet). Uber hasn’t upgraded and Fastly was concerned about DB load.

Discoverability problem: Rachael: Maybe we can light up hostnames on the query report page so folks know that you can see reports at the host level.

Demo problem: Help folks know this exists

  • Dave: For IT, it would be exciting to show the most intensive processes (CPU and memory).

FYI @sharon-fdm here's what we discussed during product office hours on 2024-05-06

@sharon-fdm
Copy link
Contributor

sharon-fdm commented May 6, 2024

@noahtalerman After doing the postmortem on this, we found that it was a specific page showing the results per host. So perhaps this specific page was not used, or maybe it was used and was not important for the customer to report since the functionality as a whole was working 🤷 ...?

@noahtalerman
Copy link
Member Author

@sharon-fdm I ran into the bug before any users reported it.

We don't know if a customer/user ran into the bug. It's possible they did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as documented #g-endpoint-ops Endpoint ops product group P2 Prioritize as urgent :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Development

No branches or pull requests

7 participants