-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cached query results on Host details page are missing #18083
Comments
## Addresses #18083 ![Screenshot 2024-04-05 at 9 37 20 AM](https://github.com/fleetdm/fleet/assets/61553566/b683d30c-9af2-4cbb-8cea-b4a6e2422464) - [x] Changes file added for user-visible changes in `changes/` - [x] Added/updated tests - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
## Addresses #18083 ![Screenshot 2024-04-05 at 9 37 20 AM](https://github.com/fleetdm/fleet/assets/61553566/b683d30c-9af2-4cbb-8cea-b4a6e2422464) - [x] Changes file added for user-visible changes in `changes/` - [x] Added/updated tests - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
@noahtalerman @sharon-fdm Reminder that per our high-priority stories and bugs documentation, all P-rated tickets should be assigned to the release ritual DRI (me) first, before being actioned. I then validate they meet the criteria before assigning them to the EM for action. If it's a P0 or P1, DM me on Slack or text me via phone so I can review it immediately. |
## Addresses #18083 ![Screenshot 2024-04-05 at 9 37 20 AM](https://github.com/fleetdm/fleet/assets/61553566/b683d30c-9af2-4cbb-8cea-b4a6e2422464) - [x] Changes file added for user-visible changes in `changes/` - [x] Added/updated tests - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
Missing query cache, |
Sharon: Following this bug, we found out that no customer is using it. Maybe there is something we could iterate on it to make it more attractive? Noah: Is that true? I think we don’t know who is using it. We only know that Uber and Fastly aren’t using it (yet). Uber hasn’t upgraded and Fastly was concerned about DB load. Discoverability problem: Rachael: Maybe we can light up hostnames on the query report page so folks know that you can see reports at the host level. Demo problem: Help folks know this exists
FYI @sharon-fdm here's what we discussed during product office hours on 2024-05-06 |
@noahtalerman After doing the postmortem on this, we found that it was a specific page showing the results per host. So perhaps this specific page was not used, or maybe it was used and was not important for the customer to report since the functionality as a whole was working 🤷 ...? |
@sharon-fdm I ran into the bug before any users reported it. We don't know if a customer/user ran into the bug. It's possible they did. |
Fleet version: Fleet 4.48
💥 Actual behavior
Cached query results show
val
as the result for all columns:🧑💻 Steps to reproduce
Not sure.
🕯️ More info (optional)
Looks like it's a frontend bug. The GET /hosts/:host_id/queries/:query_id is returned results:
The text was updated successfully, but these errors were encountered: