Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar fails validation in GitOps on initial enablement #18299

Closed
getvictor opened this issue Apr 16, 2024 · 1 comment
Closed

Calendar fails validation in GitOps on initial enablement #18299

getvictor opened this issue Apr 16, 2024 · 1 comment
Assignees
@getvictor
Labels
~backend Backend-related issue. bug Something isn't working as documented #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.49.0

Comments

@getvictor
Copy link
Member

Fleet version:
4.48.0
Web browser and operating system:

💥  Actual behavior

When enabling Calendar integration (global and team together) via GitOps, validation for team --dry-run fails because global setting is not set.

🧑‍💻  Steps to reproduce

  1. Make sure Calendar integration is not set (at global and team levels)
  2. Create a team gitops file enabling calendar integration. (It is implied that you also have a global gitops file that enables the global integration.)
  3. Do `fleetctl gitops -f --dry-run

🕯️ More info (optional)

N/A
@getvictor getvictor added #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. bug Something isn't working as documented ~backend Backend-related issue. ~released bug This bug was found in a stable release. labels Apr 16, 2024
@getvictor getvictor self-assigned this Apr 16, 2024
@getvictor getvictor mentioned this issue Apr 16, 2024
Merged
3 tasks
getvictor added a commit that referenced this issue Apr 16, 2024
@getvictor
Fixed fleetctl gitops dry-run validation issues when enabling calenda…
6b2ab24 
…r integration for the first time. (#18301)

#18299
Fixed fleetctl gitops dry-run validation issues when enabling calendar
integration for the first time.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
@sharon-fdm sharon-fdm added this to the 4.49.0-tentative milestone Apr 18, 2024
@fleet-release
Copy link
Contributor

Calendar validation,
In GitOps, now seamless,
Fleet soars, unbroken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getvictor getvictor

Labels
~backend Backend-related issue. bug Something isn't working as documented #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.49.0
Development

No branches or pull requests
4 participants
@lukeheath @getvictor @fleet-release @sharon-fdm