Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing/out-of-date verbiage in software empty states #19181

Open
13 of 18 tasks
rachaelshaw opened this issue May 21, 2024 · 1 comment
Open
13 of 18 tasks

Confusing/out-of-date verbiage in software empty states #19181

rachaelshaw opened this issue May 21, 2024 · 1 comment
Assignees
@RachelElysia
Labels
bug Something isn't working as documented ~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.53.0-tentative

Comments

@rachaelshaw
Copy link
Member

rachaelshaw commented May 21, 2024 •
edited by jacobshandling

Fleet version: 4.49.4

💥  Actual behavior

  • When there is no software, the empty state mentions search criteria (but there is no search field)
  • When there is software but doesn't match search criteria, we use out-of-date "to preserve performance" language (moving away from that language in other places, since we don't want to imply that using these features is bad for device performance)
  • Using the same empty state language for vulnerabilities and OS tabs is a little confusing

🛠️ To fix

Figma

  • SW
    • SW
      • update "No software" empty state
      • update no software matches filters empty state
    • OS–> "expecting to see operating systems?"
      • no OS
    • Vuln –> "expecting to see vulnerabilities?"
      • No vulns
      • No filtered vulns

QA

  • SW
    • SW
      • update "No software" empty state
      • update no software matches filters empty state
    • OS–> "expecting to see operating systems?"
      • no OS
    • Vuln –> "expecting to see vulnerabilities?"
      • No vulns
      • No filtered vulns
@rachaelshaw rachaelshaw added bug Something isn't working as documented :product Product Design department (shows up on 🦢 Drafting board) #g-endpoint-ops Endpoint ops product group :incoming New issue in triage process. labels May 21, 2024
@rachaelshaw rachaelshaw self-assigned this May 21, 2024
@rachaelshaw rachaelshaw added :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. and removed :product Product Design department (shows up on 🦢 Drafting board) labels May 22, 2024
@rachaelshaw rachaelshaw removed their assignment May 22, 2024
@lukeheath lukeheath added the ~released bug This bug was found in a stable release. label May 24, 2024
@sharon-fdm sharon-fdm added ~frontend Frontend-related issue. and removed :incoming New issue in triage process. labels May 30, 2024
@sharon-fdm sharon-fdm added this to the 4.52.0-tentative milestone Jun 3, 2024
@RachelElysia RachelElysia mentioned this issue Jun 13, 2024
Merged
2 tasks
@jacobshandling
Copy link
Contributor

Need to apply "search criteria" empty states to filtered results

@jacobshandling jacobshandling mentioned this issue Jun 19, 2024
Merged
1 task
jacobshandling added a commit that referenced this issue Jun 20, 2024
@jacobshandling
UI – Software pages, treat dropdown filters as search criteria for em…
ebc6e2f 
…pty states (#19888)

## Follow-up to #19181  

<img width="1480" alt="Screenshot 2024-06-19 at 2 56 04 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/303703e8-8be4-4ef5-866f-48edadc16d9f">
<img width="1480" alt="Screenshot 2024-06-19 at 2 51 28 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/56cde02b-2fee-4313-b7af-c328da1a2934">


- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RachelElysia RachelElysia

Labels
bug Something isn't working as documented ~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.53.0-tentative
Development

No branches or pull requests
5 participants
@lukeheath @rachaelshaw @jacobshandling @RachelElysia @sharon-fdm