Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website bug: Github webhook adds #handbook label to PRs with no changes. #19891

Closed
1 task
eashaw opened this issue Jun 19, 2024 · 2 comments · Fixed by #19892
Closed
1 task

Website bug: Github webhook adds #handbook label to PRs with no changes. #19891

eashaw opened this issue Jun 19, 2024 · 2 comments · Fixed by #19892
Assignees
@eashaw
Labels
bug Something isn't working as documented #g-digital-experience https://fleetdm.com/handbook/digital-experience ~website Issues related to fleetdm.com

Comments

@eashaw
Copy link
Contributor

eashaw commented Jun 19, 2024

Issue:

When a PR is updated to have no changes, the "fleet-release" bot will add a #handbook label to it.

To resolve:

  • Update the get-is-pr-handbook-only-changes helper to return false if a PR contains no changes.
@eashaw eashaw added bug Something isn't working as documented #g-digital-experience https://fleetdm.com/handbook/digital-experience ~website Issues related to fleetdm.com labels Jun 19, 2024
@eashaw eashaw self-assigned this Jun 19, 2024
@eashaw eashaw mentioned this issue Jun 19, 2024
Merged
@eashaw eashaw closed this as completed in b2e9e0a Jun 20, 2024
@fleet-release
Copy link
Contributor

Webhook bug resolved,
Quiet like a cloud city,
PRs flow untouched.

@fleet-release
Copy link
Contributor

Bot in cloud city,
Labels vanish with the mist,
Clarity restored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eashaw eashaw

Labels
bug Something isn't working as documented #g-digital-experience https://fleetdm.com/handbook/digital-experience ~website Issues related to fleetdm.com
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Website: Update Github helper fleetdm/fleet
2 participants
@eashaw @fleet-release