Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website: Follow up changes from code review meeting #20102

Closed
eashaw opened this issue Jun 28, 2024 · 2 comments · Fixed by #20174
Closed

Website: Follow up changes from code review meeting #20102

eashaw opened this issue Jun 28, 2024 · 2 comments · Fixed by #20174
Assignees
@eashaw
Labels
#g-digital-experience https://fleetdm.com/handbook/digital-experience ~website Issues related to fleetdm.com

Comments

@eashaw
Copy link
Contributor

eashaw commented Jun 28, 2024

From review meeting on 06/21

Goal:

  • Update the relative link modification in build-static-content to remove the \s replacement and either document the %20 replacement and rename the variable to be clearer or remove it.
@eashaw eashaw added #g-digital-experience https://fleetdm.com/handbook/digital-experience ~website Issues related to fleetdm.com labels Jun 28, 2024
@eashaw eashaw self-assigned this Jun 28, 2024
@eashaw eashaw mentioned this issue Jul 2, 2024
Merged
@eashaw eashaw closed this as completed in 0abe6ab Jul 2, 2024
@fleet-release
Copy link
Contributor

Code review wisdom,
like a river, guides the flow.
Links now clearer show.

@fleet-release
Copy link
Contributor

Code review's wisdom,
Like rain in a cloud city,
Mends the link's journey.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eashaw eashaw

Labels
#g-digital-experience https://fleetdm.com/handbook/digital-experience ~website Issues related to fleetdm.com
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Website: follow-up changes from backend code review fleetdm/fleet
2 participants
@eashaw @fleet-release