-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update /macadmins
endpoints to include MDM name and aggregate count
#6732
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
/macadmins
endpoints to include MDM name and aggregate count
@lukeheath typo |
@RachelElysia Thanks! Fixed. It was also wrong in the API docs (where I copied it from), so I've put in a PR to fix that as, well. |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
@lukeheath @noahtalerman I'll document that the new Another thing I wanted to point out is that typically, when adding information to hosts we're careful with the migrations time as there may be a lot of hosts, so what I did is that the MDM name and aggregate stats are not computed at migration time for existing hosts, it will be gradually done as hosts send back the MDM osquery results. I think in most cases this means that within an hour (the |
@mna makes sense to me!
Can you please make sure that this explanation is included in the /changes file for this feature? This way, we'll remember to explain the behavior to users in the release notes. |
Sure thing, will do. Thanks! |
I ran a load test for the backend data ingestion part (making sure the ingestion could properly handle the new |
@mna During implementation on the frontend, @RachelElysia pointed out that we have one additional requirement on the backend to fully implement this issue. I've added the new spec as item 6 in the description above. On Monday, would you please prioritize adding this spec, and ask that the review process be expedited on the backend? We need to get that in so Rachel can finish the frontend and get that merged, which we're hoping to do by EOD Monday so that this feature can be included in the next release. Sorry for the last minute fire drill! Fortunately I think this will be a pretty quick and easy change. Please let @RachelElysia know the status of this as it is completed on Monday. |
@lukeheath @chiiph Allright so I implemented the last (6th) bullet, one thing to keep in mind is that for now I haven't implemented any cleanup logic of the new AFAICS, there is also no cleanup logic for the general Let me know if y'all want me to create issues for those (one per table), it may not be worth it but wanted to double-check especially for the mdm solutions one. |
Deferring the cleanup makes sense to me, yeah. |
Goal
For MacOS hosts, add ability to know which host is enrolled in an undesired Mobile Device Management (MDM) solution.
Figma
https://www.figma.com/file/hdALBDsrti77QuDNSzLdkx/%F0%9F%9A%A7-Fleet-EE-(dev-ready%2C-scratchpad)?node-id=7652%3A275866
Related
Tasks
1
GET /api/v1/fleet/hosts/{id}/macadmins
endpoint to provide MDM solution name.null
for all other cases but still grouped byserver_url
.server_url
should be unique. There may be multiple identicalname
rows, but theserver_url
will be unique.Example response
2
GET /api/v1/fleet/macadmins
endpoint to include newmobile_device_management_solution
array.team_id
query param. Example:GET /api/v1/fleet/macadmins?team_id=3
New endpoint response example:
Example UI
We will use the new aggregated counts in this table:
3
GET /api/v1/fleet/hosts
endpoint as needed so that hosts can be filtered bymdm
id.host_mdm
table, but it looks like it may be time to add amobile_device_management
table.4
GET /api/v1/fleet/hosts
endpoint as needed so that hosts can be filtered by mdm enrollment status./hosts/manage/?mdm_enrollment_status=manual
/hosts/manage/?mdm_enrollment_status=automatic
/hosts/manage/?mdm_enrollment_status=unenrolled
5
6
mobile_device_management_solution
object toGET /hosts
response whenmdm_id
filter applied.Example response:
This is similar to how a
software
object is returned with the payload when a software id filter is applied. Because there are no dedicated endpoints to retrieve MDM details bymdm_id
, we need the object included in this response payload in order to populate the filter data in the UI.The text was updated successfully, but these errors were encountered: