Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare v4.38.1 #14303

Merged
merged 1 commit into from
Oct 5, 2023
Merged

prepare v4.38.1 #14303

merged 1 commit into from
Oct 5, 2023

Conversation

roperzh
Copy link
Member

@roperzh roperzh commented Oct 4, 2023

No description provided.

@roperzh roperzh requested a review from lukeheath October 4, 2023 21:04
@roperzh roperzh temporarily deployed to Docker Hub October 4, 2023 21:04 — with GitHub Actions Inactive
@roperzh roperzh marked this pull request as ready for review October 4, 2023 21:05
@roperzh roperzh requested review from edwardsb and a team as code owners October 4, 2023 21:05
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a40db25) 58.79% compared to head (0a5ce56) 58.79%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14303   +/-   ##
=======================================
  Coverage   58.79%   58.79%           
=======================================
  Files         905      905           
  Lines       74500    74500           
  Branches     2100     2100           
=======================================
  Hits        43804    43804           
  Misses      27197    27197           
  Partials     3499     3499
Flag Coverage Δ
frontend 53.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rfairburn
rfairburn approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@rfairburn rfairburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra changes look ok

@lukeheath lukeheath merged commit 6702e3d into main Oct 5, 2023
19 of 21 checks passed
@lukeheath lukeheath deleted the prepare-fleet-v4.38.1 branch October 5, 2023 16:13
lukeheath pushed a commit that referenced this pull request Oct 5, 2023
@lukeheath
prepare v4.38.1 (#14303)
22b0136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeheath lukeheath lukeheath approved these changes

@rfairburn rfairburn rfairburn approved these changes

@edwardsb edwardsb Awaiting requested review from edwardsb edwardsb is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roperzh @lukeheath @rfairburn