Windows friendly changes after walking through getting started guide #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
edwardsb
commented
Jul 21, 2021
edwardsb
commented
- update gitattributes to be explicit about line endings with regards to the test certs
- update building-fleet guide to include python2 dependency on windows (this usually comes for free on other OS's so easy to miss
- update configuration to default to OS specific temporary directories
…o the test certs, update building-fleet guide to include python2 dependency on windows (this usually comes for free on other OS's so easy to miss, update configuration to default to OS specific temporary directories
chiiph
reviewed
Jul 21, 2021
zwass
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Thanks!
Take a look at https://github.com/fleetdm/fleet/blob/main/docs/3-Contributing/4-Committing-Changes.md#merging-pull-requests and merge away 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.