Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make receive calls to redis conn thread safe #1641

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Make receive calls to redis conn thread safe #1641

merged 2 commits into from
Aug 11, 2021
+49 −77

Conversation

chiiph
Copy link
Contributor

@chiiph chiiph commented Aug 11, 2021

Also removes REDIS_TEST env var. Redis is lightweight and fast, no need to skip these tests.

@chiiph
Make receive calls to redis conn thread safe
45f8525 
Also removes REDIS_TEST env var. Redis is lightweight and fast, no need
to skip these tests.
@chiiph
No need to increase the wait
0074d44
@chiiph chiiph requested review from zwass and edwardsb August 11, 2021 19:58
This was linked to issues Aug 11, 2021
Question about using redigo for that it does not support concurrently Receive and Close #1531
Closed
Leaking Redis connections when client disconnects the websocket used for live query? (ERR max number of clients reached) #1541
Closed
@chiiph chiiph mentioned this pull request Aug 11, 2021
Closed
@noahtalerman noahtalerman mentioned this pull request Aug 11, 2021
Merged
@chiiph chiiph merged commit 3d8a766 into main Aug 11, 2021
@chiiph chiiph deleted the redigo-thread-safe-receive branch August 11, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwass zwass zwass approved these changes

@edwardsb edwardsb Awaiting requested review from edwardsb

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@chiiph @zwass