API design: Deploy security agents to macOS, Windows, and Linux hosts #17865
+372
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API design for: - #14921
22 tasks
mna
reviewed
May 1, 2024
| "name": "Google Chrome.app", | ||
| "package_available_for_install": "GoogleChrome.pkg", | ||
| "source": "apps", | ||
| "bundle_identifier": "com.google.Chrome", |
There was a problem hiding this comment.
Reminder to remove bundle_identifier from the response as discussed on slack.
gillespi314
reviewed
May 1, 2024
|
|
||
| #### Example | ||
|
|
||
| `GET /api/v1/fleet/software/install/results` |
There was a problem hiding this comment.
Example is missing the uuid path parameter:
Suggested change
| `GET /api/v1/fleet/software/install/results` | |
| `GET /api/v1/fleet/software/install/results/b15ce221-e22e-4c6a-afe7-5b3400a017da` |
|
|
||
| | Name | Type | In | Description | | ||
| | ---- | ------- | ---- | -------------------------------------------- | | ||
| | installation_uuid | string | path | **Required**. The installation UUID of the software.| |
There was a problem hiding this comment.
Suggested change
| | installation_uuid | string | path | **Required**. The installation UUID of the software.| | |
| | install_uuid | string | path | **Required**. The installation UUID of the software.| |
Name of the param should be modified to match the corresponding API response field.
|
|
||
| _Available in Fleet Premium_ | ||
|
|
||
| `GET /api/v1/fleet/software/install/results` |
There was a problem hiding this comment.
Missing path param:
Suggested change
| `GET /api/v1/fleet/software/install/results` | |
| `GET /api/v1/fleet/software/install/results/:install_uuid` |
|
@marko-lisica, draft docs are missing the changes for the new |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API design for: