Interpret windows exit codes as a signed integer #18282
Conversation
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Error
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Error
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
| @@ -128,7 +128,7 @@ func (ds *Datastore) SetHostScriptExecutionResult(ctx context.Context, result *f | |||
| res, err := tx.ExecContext(ctx, updStmt, | |||
| output, | |||
| result.Runtime, | |||
| result.ExitCode, | |||
| int32(result.ExitCode), | |||
There was a problem hiding this comment.
Nit but I don't think this is necessary.
There was a problem hiding this comment.
Oh I see that it might be just for the test case (otherwise the cast to signed happens in fleetd, not server-side). That's fine to leave it there but if you have a sec to add a comment as for the why of this, as it's the kind of thing someone may see and have a reflex to remove as unnecessary.
There was a problem hiding this comment.
I'd be very happy to put a comment 🙂
There was a problem hiding this comment.
I added it to the server as well because I wanted to make sure the bug gets fixed for clients where orbit can't be updated for some reason
There was a problem hiding this comment.
Would you prefer I remove the server-side overflow check and just rely on the client?
There was a problem hiding this comment.
No, your rationale makes sense to me!
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
#17695 The windows exit code is a 32-bit unsigned integer, but the command interpreter treats it like a signed integer. When a process is killed, it returns 0xFFFFFFFF (interpreted as -1). We convert the integer to an signed 32-bit integer to flip it to a -1 to match our expectations, and fit in our db column. https://en.wikipedia.org/wiki/Exit_status#Windows FIxed on both the client and server side.
#17695
The windows exit code is a 32-bit unsigned integer, but the command interpreter treats it like a signed integer. When a process is killed, it returns 0xFFFFFFFF (interpreted as -1). We convert the integer to an signed 32-bit integer to flip it to a -1 to match our expectations, and fit in our db column.
https://en.wikipedia.org/wiki/Exit_status#Windows
FIxed on both the client and server side.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.