-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional stats #19078
additional stats #19078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Left a couple of nit comments.
- Missing
changes/
file. - Add tests to
server/datastore/mysql/statistics_test.go
.
Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please create a separate issue to change the statistics cron job to use the DB reader instance instead of the DB writer instance.
Additional telemetry stats to report to Heroku.
FYI - @eashaw, we could later add to datadog as well.