API design: Get unlock PIN immediately after locking macOS host

[noahtalerman]

UPDATE: Here's the new PR:

• API design: Get unlock PIN immediately after locking macOS host #20123

Proposed API changes for the "Get unlock PIN immediately after locking macOS host" story (#19545)

[noahtalerman]

Hey @rachaelshaw do you remember why we decided to include the host_id in the response for the unlock endpoint? https://fleetdm.com/docs/rest-api/rest-api#default-response-macos-hosts

I omitted host_id in the lock response because I don't think we need it. But maybe we should add it for consistency?

Also, I updated the status code from 204 to 200. Breaking change?

[rachaelshaw]

Hey @rachaelshaw do you remember why we decided to include the host_id in the response for the unlock endpoint? https://fleetdm.com/docs/rest-api/rest-api#default-response-macos-hosts

@noahtalerman I don't remember why we included it, and can't find any conversation about it in the original PR. Doesn't seem necessary. I'm feeling torn between being consistent and simplifying the response; probably makes sense to simplify though.

Also, I updated the status code from 204 to 200. Breaking change?

Shouldn't be since it's still a 2xx status code

[rachaelshaw]

@noahtalerman converted to draft PR since this isn't implemented yet

[noahtalerman]

Closing this draft PR and opening a new one so we don't affect the PR open time KPI.