fix: don't allow observer and observer+ to download software installers #19938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roperzh
reviewed
Jun 24, 2024
| allow { | ||
| not is_null(object.team_id) | ||
| object.type == "software_installer" | ||
| team_role(subject, object.team_id) == [admin, maintainer, observer, observer_plus][_] | ||
| team_role(subject, object.team_id) == [admin, maintainer][_] |
There was a problem hiding this comment.
I think the problem (and the confusing part) is that they can read installers, but they can't download them, I believe this will restrict both actions.
There was a problem hiding this comment.
I was still able to read (list and access the details page) fwiw; I think those actions are permissioned using the software titles object, which allows the access
There was a problem hiding this comment.
good point, thanks! how do you see that playing out with the upcoming changes in #19561?
roperzh
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.