Match macOS software <-> titles using bundle identifier

[roperzh]

for #19144 and #20171

Checklist for submitter

If some of the following don't apply, delete the relevant line.

• Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  See Changes files for more information.
• Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
• Added/updated tests
• If database migrations are included, checked table schema to confirm autoupdate
• For database migrations:
  • Checked schema for all modified table for columns that will auto-update timestamps during migration.
  • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).
• Manual QA for all new/changed functionality

[roperzh]

this binary was created using this script:

#!/bin/bash

PACKAGE_ID="com.example.dummy"
PACKAGE_VERSION="1.0.0"
INSTALL_LOCATION="DummyApp.app"

TEMP_DIR=$(mktemp -d)
PAYLOAD_DIR="$TEMP_DIR/payload"

mkdir -p "$PAYLOAD_DIR"
pkgbuild --root "$PAYLOAD_DIR" --identifier "$PACKAGE_ID" --version "$PACKAGE_VERSION" "$TEMP_DIR/dummy.pkg"

DISTRIBUTION_XML="$TEMP_DIR/Distribution"
cat <<EOF > "$DISTRIBUTION_XML"
<?xml version="1.0" encoding="utf-8"?>
<installer-script minSpecVersion="1.0">
    <title>Dummy Installer</title>
    <choices-outline>
        <line choice="default">
            <line choice="dummy"/>
        </line>
    </choices-outline>
    <choice id="default"/>
    <pkg-ref id="$PACKAGE_ID" version="$PACKAGE_VERSION" auth="root">
      <bundle-version>
	<bundle CFBundleShortVersionString="$PACKAGE_VERSION" CFBundleVersion="$PACKAGE_VERSION" id="$PACKAGE_ID" path="$INSTALL_LOCATION"/>
      </bundle-version>
    </pkg-ref>
</installer-script>
EOF

productbuild --distribution "$DISTRIBUTION_XML" --resources "$TEMP_DIR" --package-path "$TEMP_DIR" "dummy_installer.pkg"
rm -rf "$TEMP_DIR"
echo "Dummy .pkg installer created: dummy_installer.pkg"

[mna]

Looks great (and I did manually test the fix for another ticket, worked perfectly)!

Only some questions where I was unsure about the handling of NULLs.

[roperzh]

hey @getvictor, can you take a look at this when time allows? pinging you as a code owner and because from the git blame I think you have the most context.

[gillespi314]

LGTM! Just a minor question for my own curiosity.

[getvictor]

The changes look good.

Probably too late now, but I would have used a more generic identifier instead of Apple-specific bundle_identifier so that we can reuse this for Windows/Linux/etc later if needed.