New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better handling of path differences for MSI installers #7035
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7035 +/- ##
==========================================
+ Coverage 59.72% 59.97% +0.25%
==========================================
Files 405 403 -2
Lines 37877 37712 -165
==========================================
- Hits 22622 22619 -3
+ Misses 13038 12876 -162
Partials 2217 2217
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -39,14 +25,14 @@ func Heat(path string, native bool) error { | |||
args = append( | |||
args, | |||
"docker", "run", "--rm", "--platform", "linux/amd64", | |||
"--volume", path+":"+path, // mount volume | |||
"--volume", path+":/wix", // mount volume |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was the crux of the problem, as we were providing Windows-like paths on Windows for the bind mount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Were you able to test both modes? (native
and !native
)
yes! I updated the list in the PR description to include
|
Related to #7036, Tested in:
fleetctl package --type=msi
(non-native)docker run -v "$(pwd)" fleetdm/fleetctl package --type=msi
(native)fleetctl pacakge --type=msi
(thanks to @edwardsb) (non-native)Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/
and/ororbit/changes/
).