New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
title when sharing note #738
Conversation
@@ -40,9 +40,12 @@ class NoteEditorAppBar extends ConsumerWidget { | |||
return; | |||
} | |||
final box = context.findRenderObject() as RenderBox?; | |||
String? title = titleController?.text; | |||
String concatenatedText = title != null ? "$title\n$content" : content; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work on this!
if (kIsWeb) { | ||
await Clipboard.setData( | ||
ClipboardData(text: contentController?.text ?? '')); | ||
await Clipboard.setData(ClipboardData(text: content)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the clipboard data should be set as concatenatedText
as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 502ad25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When sharing from web, it should include the title as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.