Save searches #869
Merged
Save searches #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gonzalovelasco
commented
Aug 11, 2023
•
gonzalovelasco
commented
|
make the UI look like Google Keep, add divider and a title saying saved saerches + a button to "Create/Edit searches" ? Instead of labels: "Saved Searches" |
gonzalovelasco
force-pushed
the
save-searches
branch
from
1d387a9
to
0de9024
Compare
matthewwong525
requested changes
Aug 16, 2023
| }, | ||
| ), | ||
| ), | ||
| Padding( |
There was a problem hiding this comment.
remove the done button
There was a problem hiding this comment.
Fixed 49a0cb7
| itemCount: widget.searches.length, | ||
| itemBuilder: (context, index) { | ||
| String editedText = widget.searches[index]; | ||
| return ListTile( |
There was a problem hiding this comment.
Add leading search icon like how they added label icon in Google Keep
Co-authored-by: Matthew Wong <matthewwong525@gmail.com>
Co-authored-by: Matthew Wong <matthewwong525@gmail.com>
matthewwong525
approved these changes
Aug 21, 2023
gonzalovelasco
added a commit
that referenced
this pull request
Aug 28, 2023
* add new setting field for searches * add icon in search bar * save search * list the searchs in the menu * get the searches * remove save search in searchbar * update menu to show a button to add new searches * create search dialog to add or remove new searches * show dialog searches * use dynamic dialog and implement edit * implement functions to add, edit and remove * fix sidemu to show the list of searches * fix style * remove unused import * Update lib/screens/main/components/create_search_dialog.dart Co-authored-by: Matthew Wong <matthewwong525@gmail.com> * Update lib/screens/main/components/create_search_dialog.dart Co-authored-by: Matthew Wong <matthewwong525@gmail.com> * remove done button * add search icon and delete icon like google keep * add tests --------- Co-authored-by: Matthew Wong <matthewwong525@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.