Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: add other properties types to svelte transition functions #94

Merged
merged 1 commit into from Jan 2, 2023

Conversation

leovoon
Copy link
Contributor

@leovoon leovoon commented Dec 30, 2022

Background

I'm trying to use another transition function as follows

<script lang='ts'>
  import { fly } from 'svelte/transition'

</script>

<Modal
  transitionWindow={fly}
  transitionWindowProps={{ y: 50, duration: 300 }} // Typescript is not happy
</Modal>

Currently Observed Behavior

The type is currently only supported for blurparam. This PR adds properties for fly, fade and slide functions and updates docs.

New Behavior

No typescript warnings

@flekschas flekschas self-requested a review January 2, 2023 21:01
@flekschas flekschas added the improvement Improved feature label Jan 2, 2023
Copy link
Owner

@flekschas flekschas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the type definitions! This looks good to me.

@flekschas flekschas merged commit 487b2a3 into flekschas:master Jan 2, 2023
@flekschas
Copy link
Owner

New version with the improved type definition is out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improved feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants