Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metal Max 2 Kai (Japan) flashing text #89

Closed
benderscruffy opened this issue May 14, 2020 · 4 comments
Closed

Metal Max 2 Kai (Japan) flashing text #89

benderscruffy opened this issue May 14, 2020 · 4 comments
Assignees
@fleroviux
Labels
accuracy bug hw: ppu

Comments

@benderscruffy
Copy link

the text keeps flashing during the game
@fleroviux fleroviux self-assigned this May 14, 2020
@fleroviux
Copy link
Member

Can confirm.

@fleroviux
Copy link
Member

fleroviux commented May 14, 2020 •
edited

image

Thank you for testing so many games! This one should work fine now.

@fleroviux
Copy link
Member

fleroviux commented Nov 21, 2020 •
edited

The fix for this game actually seems to be incorrect and made H-blank IRQs fire too early.
This game is extremely tight on timing. It polls the scanline counter for one specific value/scanline and if the H-blank IRQ is just a bit too late that scanline will already have passed. Needs more investigation. Maybe also related to general IRQ delay?

@fleroviux fleroviux reopened this Nov 21, 2020
@fleroviux fleroviux mentioned this issue Sep 15, 2021
Closed
fleroviux added a commit that referenced this issue Jul 10, 2022
@fleroviux
PPU: delay H-blank IRQs by four cycles (fixes #89, fixes #175)
541bd5d
@fleroviux fleroviux mentioned this issue Jul 10, 2022
Closed
@fleroviux
Copy link
Member

The flickering text issue is now finally resolved for good (the fix 100% matches hardware timing).
But there still are a few minor graphical issues left that are unrelated to the original bug.
I've created a new issue here, to track these:
#229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fleroviux fleroviux

Labels
accuracy bug hw: ppu
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benderscruffy @fleroviux