-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix absolute and relative paths #5
Conversation
fs.resolve allow to specify relative paths appending process.cwd() but skip absolute paths.
Hi, what's the purpose of this change? did you have any problem? |
Yep. I was trying to read configs which are stored in directory outside of application and CWD, but could not do that with absolute nor relative paths. |
Thank you flesler for for that module - and thank you rumkin for making it useable for my needs. |
@rumkin @oger000 I made a commit that includes the line you suggested plus tests, a version bump and more. Can you guys try this version and confirm it now works? I won't publish it to NPM until it's confirmed. I noted that, on Windows+GitBash, using something like Thanks |
UPDATE: Tried using Can you please re-test? I added 2 tests and they all pass. |
Releasing it then |
I can't test it on windows. Tested on ubuntu 14.04 and MacOS. All tests are passed. |
Does your case now work with these changes? |
Yes, it works fine. Thanks! |
Works for me. |
Great, I published 1.3.0. Just in case I bumped the minor version |
fs.resolve allow to specify relative paths appending process.cwd() but skip absolute paths.