Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using animate+step+window.scrollTo/$().scrollTop() #107

Closed
flesler opened this issue Mar 4, 2015 · 12 comments
Closed

Try using animate+step+window.scrollTo/$().scrollTop() #107

flesler opened this issue Mar 4, 2015 · 12 comments
Assignees
Labels

Comments

@flesler
Copy link
Owner

flesler commented Mar 4, 2015

Found some alternative approaches mentioned on StackOverflow linked by @westurner in here.

It could be an alternative solution to all the _scrollable() feature detection.

@flesler
Copy link
Owner Author

flesler commented Mar 4, 2015

Done implemented on branch window-scroll-alt.
Added tests from this branch side by side to those from the window-scroll branch #101

I'd appreciate if people could try the new tests on their available platforms and comment on the results.

@flesler
Copy link
Owner Author

flesler commented Mar 4, 2015

I decided that if this alternative was to prevail, it should be 2.0.0 rather than 1.5.0 because it's even less backwards-compatible than the other option and it contains a highly requested and powerful feature.

@markvantilburg
Copy link

Windows Phone 8.1:

These do not animate:
Max window scrolling, within an iframe (compat mode)
Max window scrolling, within an iframe (quirks mode)
Max iframe scrolling from outside (compat mode)
Max iframe scrolling from outside (quirks mode)

In the old version they did animate but not always, depending on when what was loaded.

200-wp81

200-wp81-desktop

@flesler
Copy link
Owner Author

flesler commented Mar 5, 2015

Ok, I'm less concerned about the iframe cases honestly, they are rare. It could be due to a bad test implementation it's not top quality.
Do you know when did those iframe tests failed on the 1.5.0 version? I'd like to try and fix it if really a bug on the test.

@markvantilburg
Copy link

It has to do with timing i guess. When i select the iframe and refresh only that the scrolling happens. Otherwise it's just puts the "agent information" instantly.

@flesler
Copy link
Owner Author

flesler commented Mar 6, 2015

Same happens with 2.0.0 or that one never works at all?

@markvantilburg
Copy link

In the 2.0.0 nothing happens on the iframe pages. The old 1.5 did only fire if i refresh the iframe myself.

@flesler
Copy link
Owner Author

flesler commented Mar 12, 2015

Windows 7
Firefox 36.0.1 - ALL OK
Chrome 41.0.2272.76 - ALL OK
IE 10.0.9200.16750 - ALL OK

@flesler
Copy link
Owner Author

flesler commented Mar 12, 2015

iPhone 4S
Chrome 40.0.2214.73 - ALL OK except iframes
Safari (not sure where's the version) - ALL OK except iframes

I think the iframes don't work just because the tests are not rendered correctly on these browsers, the iframe is full height without overflow. I did a few changes but still no luck, I don't worry much about it honestly.

@flesler
Copy link
Owner Author

flesler commented Mar 12, 2015

Mac OSX Yosemite 10.10.1
Chrome 41.0.2272.89 - ALL OK
Safari 8.0 - ALL OK

@flesler
Copy link
Owner Author

flesler commented Mar 17, 2015

I'd really like to release this as 2.0.0, was hoping more people could test it.
I might release it and if any issue arises fix it for 2.0.1.
Considering it's a major version bump complete backwards compatibility shouldn't be expected anyway.

@flesler
Copy link
Owner Author

flesler commented Mar 18, 2015

I merged 2.0.0 to master via #109.
If you have any issue after the update, first check this link, If your problem is not solved then go ahead and report the issue.

@flesler flesler closed this as completed Mar 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants