Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility methods: add(), remove(), insert() #3053

Closed
wants to merge 9 commits into from
Closed

Conversation

ndonkoHenri
Copy link
Collaborator

@ndonkoHenri ndonkoHenri commented Apr 18, 2024

  • New methods in some controls: add(), remove(), insert()
  • If Control.auto_update=True, then changing any property of the control should internally trigger Control.update() (needs discussion on its implementation)

@bleudev
Copy link
Contributor

bleudev commented May 1, 2024

idea with auto_update is very good! I want this pull to be merged!

Copy link
Contributor

@bleudev bleudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update!

@ndonkoHenri
Copy link
Collaborator Author

Thanks for your feedback!

It was actually planned to remove the changes concerning auto_update prop only, mainly for it to be better rethought to avoid future issues.

Happy to know you find it useful.

@ndonkoHenri ndonkoHenri changed the title Auto-update of Control Add utility methods: add(), remove(), insert() May 15, 2024
@ndonkoHenri
Copy link
Collaborator Author

Auto-update has been removed - its implementation needs to be rediscussed.

@Kacper-OS
Copy link
Contributor

I think Auto-update should be added as page parameter, and be triggered by any change to any control

@ndonkoHenri
Copy link
Collaborator Author

Thanks for the idea/suggestion @Kacper-OS !

You mean it shouldn't be exposed in all controls?

@Kacper-OS
Copy link
Contributor

basically, yeah

@ndonkoHenri
Copy link
Collaborator Author

Alright, taking note - Thanks again!

@bleudev
Copy link
Contributor

bleudev commented May 19, 2024

I think Auto-update should be added as page parameter, and be triggered by any change to any control

I already implemented this in my pull #3172

@ndonkoHenri
Copy link
Collaborator Author

Closing this PR as everything needs to be rediscussed - #3329.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants