Cherry pick on 24.2 #207
Merged
Cherry pick on 24.2 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Found a issue that the unit conversion is skipped for some reason * fixed dimensioned values for slices --------- Co-authored-by: Maciej Skarysz <maciej@flexcompute.com>
* Add constants Field in expression Initial condition Remove the comments * Fix unit test
* remove CfTagent and CfNormal as they are no longer supported * fix test
chai-flex
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
details:
https://docs.google.com/spreadsheets/d/1046uphdVYO0rLpXiwcIJfhjKCUrsIxOX7glM29eUs5Y/edit#gid=224060470