Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when support user is None #295

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

benflexcompute
Copy link
Contributor

No description provided.

Copy link

@lei-flex lei-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix and ship it.

@@ -58,6 +58,8 @@ def _get_supported_users():
try:
response = http.portal_api_get("auth/credential")
supported_users = response["guestUsers"]
if supported_users is None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if supported_users:
for entry in supported_users:
entry["userEmail"] = entry.pop("email")
entry["userIdentity"] = entry.pop("identity")
return supported_users

@benflexcompute benflexcompute merged commit 16caa8b into release-candidate/24.2 Jun 3, 2024
3 of 12 checks passed
benflexcompute added a commit that referenced this pull request Jun 3, 2024
* Fix when support user is None

* Comment addressed
maciej-flexcompute pushed a commit that referenced this pull request Jun 5, 2024
* Fix when support user is None (#295)

* Fix when support user is None

* Comment addressed

* Fix unit test (#296)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants