Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Coverage: PolySlab #522

Closed
tylerflex opened this issue Sep 29, 2022 · 0 comments · Fixed by #548
Closed

Test Coverage: PolySlab #522

tylerflex opened this issue Sep 29, 2022 · 0 comments · Fixed by #548
Assignees
@weiliangjin2021

Comments

@tylerflex
Copy link
Collaborator

There are some edge cases in the polyslab that are not covered by tests.
Let's include some more testing to make sure that, for example, and error is raised if an invalid poylsab is created.
See #516 for more details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weiliangjin2021 weiliangjin2021

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Polyslab: test coverage and fix an intersection plot issue flexcompute/tidy3d
2 participants
@weiliangjin2021 @tylerflex