Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docstrings for Gaussian beam sources to clarify the location of the waist #1043

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Improve docstrings for Gaussian beam sources to clarify the location of the waist #1043

merged 1 commit into from
Aug 3, 2023

Conversation

shashwat-sh
Copy link
Contributor

No description provided.

xin-flex
xin-flex requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@xin-flex xin-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"behind" or "in front of" are still a bit ambiguous (what is the view point?). Is it possible to use words like "to the + direction of" instead?

@shashwat-sh shashwat-sh force-pushed the shash/better_gaussian_source_docstrings branch from 6d2b1a8 to 0e2c2d7 Compare August 2, 2023 16:34
@shashwat-sh
Copy link
Contributor Author

"behind" or "in front of" are still a bit ambiguous (what is the view point?). Is it possible to use words like "to the + direction of" instead?

@xin-flex thanks, updated based on the comment

xin-flex
xin-flex approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@xin-flex xin-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@shashwat-sh
Copy link
Contributor Author

Can I go ahead and merge this?

@tylerflex tylerflex merged commit 5112ed8 into pre/2.4 Aug 3, 2023
11 checks passed
@tylerflex tylerflex deleted the shash/better_gaussian_source_docstrings branch August 3, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerflex tylerflex tylerflex approved these changes

@xin-flex xin-flex xin-flex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shashwat-sh @tylerflex @xin-flex