added bounding capabilities for plot and plot_eps #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alec-flexcompute
force-pushed
the
alec/issue723
branch
4 times, most recently
from
d74615a
to
7215c25
Compare
tylerflex
requested changes
Jul 31, 2023
There was a problem hiding this comment.
Thanks @alec-flexcompute , I had a few refactors and minor comments. Feel free to take your time and work on this and then reassign me to review. Otherwise looks good and it's almost ready!
|
Also, to check some of the formatting tests locally, make sure to run the tests are failing now due to some warnings related to the |
alec-flexcompute
force-pushed
the
alec/issue723
branch
6 times, most recently
from
a55b30a
to
b7dc2e1
Compare
tylerflex
requested changes
Aug 3, 2023
alec-flexcompute
force-pushed
the
alec/issue723
branch
from
b7dc2e1
to
709302b
Compare
tylerflex
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.