Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library updated using the fast fitter and inclusion of Palik materials #1047

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

e-g-melo
Copy link
Collaborator

@e-g-melo e-g-melo commented Aug 1, 2023

Issues #1021 and #1022.

  • A lot of materials were updated and improved using the new fast fitter.
  • Inclusion of Palik materials: Si, SiO2, GaAs, Ge, InP, and InAs.
  • The Palik materials were split into lossless and lossy wavelength ranges to improve the fits.

Copy link
Contributor

@tomflexcompute tomflexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @e-g-melo . I randomly tested a few and they all look good. The inclusions of palik Si and SiO2 are going to be very welcomed by users in the PIC industry!

@tomflexcompute
Copy link
Contributor

tomflexcompute commented Aug 1, 2023

By the way could you add it to the change log? Something like "improved fitting for materials in the material library. Added a number of common semiconductor materials such as Si, GaAs, and InP from Palik to the material library."

Also I see a conflict which is due to another PR today that added the reference for graphene on material_refernece.py. It should be straightforward to resolve.

Copy link
Collaborator

@weiliangjin2021 weiliangjin2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good. One general comment is that if the material is based on an analytical model provided in the paper, we should use the poles referred directly from the analytical modal. This is usually indicated if the variant name has the word "Drude", "Lorentz", "Sellmeier", etc. If you find the pole is imaginary, they are likely based on Sellmeier model.

tidy3d/material_library/material_library.py Outdated Show resolved Hide resolved
tidy3d/material_library/material_library.py Show resolved Hide resolved
tidy3d/material_library/material_library.py Outdated Show resolved Hide resolved
@weiliangjin2021
Copy link
Collaborator

Here is what I would suggest:

  • A list of materials to remain in its original form
    • AlAs_FernOnton1971: Sellmeier, eps_inf in its original form is likely to be off
    • GaAs_Skauli2003: Sellmeier
    • Ge_Icenogle1976: Sellmeier, eps_inf in its original form is likely to be off
    • InP_Pettit1965: Sellmeier, eps_inf in its original form is likely to be off
    • Si3N4_Luke2015: Sellmeier
    • Si3N4_Philipp1973: Sellmeier
    • Y2O3-Nigara1968: Sellmeier
    • YAG_Zelmon1998: Sellmeier
    • cSi_SalzbergVilla1957: Sellmeier
    • cSi_Li1993_293K: Sellmeier
    • All variants that contains "PMLStable" keyword

@e-g-melo
Copy link
Collaborator Author

e-g-melo commented Aug 7, 2023

Thanks Weiliang! I've changed all these materials to their original forms.

Copy link
Collaborator

@weiliangjin2021 weiliangjin2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green light from me to merge once the commits are squashed.

…#1021 #1022.

Update all RakicLorentzDrude to be exact conversion from LorentzDrude to PoleResidual
@weiliangjin2021 weiliangjin2021 merged commit c409ad2 into pre/2.4 Aug 10, 2023
16 checks passed
@weiliangjin2021 weiliangjin2021 deleted the emerson/mat_lib_update branch August 10, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants