-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library updated using the fast fitter and inclusion of Palik materials #1047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @e-g-melo . I randomly tested a few and they all look good. The inclusions of palik Si and SiO2 are going to be very welcomed by users in the PIC industry!
By the way could you add it to the change log? Something like "improved fitting for materials in the material library. Added a number of common semiconductor materials such as Si, GaAs, and InP from Palik to the material library." Also I see a conflict which is due to another PR today that added the reference for graphene on material_refernece.py. It should be straightforward to resolve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good. One general comment is that if the material is based on an analytical model provided in the paper, we should use the poles referred directly from the analytical modal. This is usually indicated if the variant name has the word "Drude", "Lorentz", "Sellmeier", etc. If you find the pole is imaginary, they are likely based on Sellmeier model.
70a5d0a
to
db721e0
Compare
db721e0
to
5f2de18
Compare
Here is what I would suggest:
|
Thanks Weiliang! I've changed all these materials to their original forms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Green light from me to merge once the commits are squashed.
b973eaf
to
99aa149
Compare
99aa149
to
965d88d
Compare
Issues #1021 and #1022.