Option to allow DC component in GaussianPulse spectrum

[caseyflex]

Per this issue:
#690

[caseyflex]

Yeah, it modifies the shape of the spectrum a bit too but is specifically designed to have this effect I believe

…

On Fri, Aug 4, 2023 at 3:02 PM Tyler Hughes ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In tidy3d/components/source.py <#1054 (comment)>: > def amp_time(self, time: float) -> complex: """Complex-valued source amplitude as a function of time.""" twidth = 1.0 / (2 * np.pi * self.fwidth) omega0 = 2 * np.pi * self.freq0 time_shifted = time - self.offset * twidth - const = 1j + time_shifted / twidth**2 / omega0 + if self.allow_dc_component: remind me again how this works when self.allow_dc_component is False multiplying by 1j + time_shifted / twidth**2 / omega0 i guess is equivalent to subtracting out the f=0 component from the source time? — Reply to this email directly, view it on GitHub <#1054 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A3KLECKFNQXI27JPZUPRTGLXTT6HNANCNFSM6AAAAAA3EDRNWU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[tylerflex]

some pretty minor suggested changes but overall looks good!

[tylerflex]

Thanks @caseyflex looks good to me, just make sure to edit the changelog too with the "remove" convention.

[caseyflex]

Thanks @caseyflex looks good to me, just make sure to edit the changelog too with the "remove" convention.

I'd almost rather leave the changelog as it is, since the actual functionality which was added was the ability to leave in the DC component

[tylerflex]

Yea good point, might just suggest putting how to do that in the changelog, eg

... by setting `remove_dc_component=False` in `GaussianPulse`.

or something.

[tomflexcompute]

Looks good. Thanks for the implementation!

[caseyflex]

I introduced an extra factor of 1j in the case where we do not remove the DC component. This extra factor makes it agree with the case where we do remove the DC component in the limit of large omega0.