Use pytest's tmp path instead of hard-codded ones #1058
Conversation
Hard-codded paths can be an issue when tests are run in parallel or unordered, particularly in Windows. This commit removes all hard-codded paths from the test suite, replacing them with pytest's tmp_path fixture, which is also automatically cleaned after run. A few ruff warnings were also cleaned up in the process: mostly unused imports and variables, and warnings caused by a large number of matplotlib figures being created. Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
There was a problem hiding this comment.
really appreciate this @lucas-flexcompute ! just wondering about the difference between pylab and pyplot and want to make sure it doesn't change our plots in unexpected way, any thoughts on that? or what was the reasoning there?
We don't use any calls that are |
|
sounds good to me! can you squash the commits into one and then "Rebase and merge" this into 2.4? thanks! |
Hard-codded paths can be an issue when tests are run in parallel or unordered, particularly in Windows. This commit removes all hard-codded paths from the test suite, replacing them with pytest's tmp_path fixture, which is also automatically cleaned after run.
A few ruff warnings were also cleaned up in the process: mostly unused imports and variables, and warnings caused by a large number of matplotlib figures being created.