Remove warning from CustomSourceTime #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyflex
force-pushed
the
casey/customsourcetime
branch
from
b2ff877
to
04046af
Compare
tylerflex
approved these changes
Aug 18, 2023
caseyflex
force-pushed
the
casey/customsourcetime
branch
from
04046af
to
7778fe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning was previously necessary because undersampling CustomSourceTime could result in unanticipated sharp jumps in amp_time, which could lead to simulation artifacts. Now, CustomSourceTime is by default modulated at freq0. This means the typical use case can use a sampling time step much larger than the simulation dt without causing any problems.