Fixes for group_index_step validator (#1143) #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-flexcompute
force-pushed
the
lucas/group_index_validator_fixes
branch
from
42ea215
to
982fb5c
Compare
dbochkov-flexcompute
approved these changes
Sep 11, 2023
|
Let's get it in, but it needs to be merged in develop then. And move to 2.4.0 changelog. |
lucas-flexcompute
force-pushed
the
lucas/group_index_validator_fixes
branch
from
982fb5c
to
b63d2a3
Compare
Rebased to develop, but there's no 2.4 section in the CHANGELOG. Do I create one? |
|
Oh man. My bad. I merged the docs 2.4 branch to develop but not this one, only the other way round, develop into pre/2.4. Sorry about that. We can do it either way now, I can merge 2.4 into develop and you can update the PR, or you can revert it to 2.4. Sorry again. |
|
No problem, I'll revert to 2.4 then. |
Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
lucas-flexcompute
force-pushed
the
lucas/group_index_validator_fixes
branch
from
b63d2a3
to
d0a1ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@momchil-flex I'm not sure this goes into 2.4, given the timing, so I added the changes in the "unreleased" section of the changelog.