lsf - added more monitor parsing capability #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alec-flexcompute
force-pushed
the
alec/lsf_parser
branch
from
ee48ca7
to
255727f
Compare
alec-flexcompute
changed the title
alec-flexcompute
force-pushed
the
alec/lsf_parser
branch
from
255727f
to
41333d6
Compare
tylerflex
reviewed
Sep 28, 2023
alec-flexcompute
force-pushed
the
alec/lsf_parser
branch
19 times, most recently
from
f319e42
to
55a2675
Compare
tylerflex
requested changes
Sep 29, 2023
There was a problem hiding this comment.
Thanks @alec-flexcompute, just a few things for refining the test. It would be good for you to learn some of these advanced pytest features (parameterize, tmp_path) as we use them throughout the code and they are really useful.
alec-flexcompute
force-pushed
the
alec/lsf_parser
branch
4 times, most recently
from
6b7a423
to
353827f
Compare
tylerflex
approved these changes
Sep 29, 2023
|
@alec-flexcompute we will merge this into |
alec-flexcompute
force-pushed
the
alec/lsf_parser
branch
2 times, most recently
from
a1aea73
to
fe6586a
Compare
|
Rebased to 2.5 |
|
There should be just one commit in this PR, could you double check that you pulled the most recent pre/2.5 branch before rebasing? |
alec-flexcompute
force-pushed
the
alec/lsf_parser
branch
from
fe6586a
to
29c5a9e
Compare
alec-flexcompute
force-pushed
the
alec/lsf_parser
branch
3 times, most recently
from
07efa48
to
c717acf
Compare
alec-flexcompute
force-pushed
the
alec/lsf_parser
branch
from
c717acf
to
f8e2d2e
Compare
tomflexcompute
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added capability to parse in the following (marked in green) monitors from lsf. These are permittivity monitors, field time monitors, and field monitors expressed in different solvers. I currently have it so that monitors that record the same information but in different solver regimes (e.g. addindex vs addemeindex) route to the same function in the parser.
This should thus handle every monitor instance in lumerical for which there is a Tidy3D counterpart.
Also added monitor.lsf as an example lsf file for testing that includes an example of every monitor we can handle, and a patch-up handling cases where no e.g. sources, structures, monitors, and override structures are given.