2.5 changes #1190
Merged
2.5 changes #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
force-pushed
the
tyler/2.5_cleanup
branch
4 times, most recently
from
23098bd
to
cf93e73
Compare
|
@momchil-flex we should probably get this in sooner rather than later. Just want to confirm that we want to remove this colocation warning and also that this PR handles it the right way. |
tylerflex
force-pushed
the
tyler/2.5_cleanup
branch
3 times, most recently
from
41b16ad
to
77e8436
Compare
momchil-flex
approved these changes
Oct 20, 2023
|
yea that's a good point, I just pushed a separate commit (probably fine for them to be separate) to restrict this, and updated changelog. |
|
note: I think tests fail because I guess it's using the |
tylerflex
force-pushed
the
tyler/2.5_cleanup
branch
from
811ebd1
to
5107f20
Compare
|
actually it was because I forgot to exclude from the workflow, should be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few things we were going to change for 2.5, before I forget. Might be more, so we can keep this open and add to it as needed or merge whenever.