Added PECMedium to IsotropicUniformMediumType, and added PEC2D

[caseyflex]

No description provided.

[tylerflex]

seems ok to me, do we need to add a changelog item in "fixed"?

Asking @shash-sharma for a review too since I'm not totally following the original problem this is fixing.

[momchil-flex]

Sorry, what is the status of this? @shash-sharma ?

[shashwat-sh]

I think we're waiting on PEC subpixel, and some revisions on this and the associated backend PR

[momchil-flex]

PEC subpixel will almost certainly not be in 2.5 - are you saying this and the backend PRs should then also not be labeled as 2.5?

[caseyflex]

Weiliang had a proposal on the backend PR that could be implemented before PEC subpixel as far as I am aware. I haven’t looked into implementing it yet.

…

On Fri, Oct 20, 2023 at 6:58 PM momchil-flex ***@***.***> wrote: PEC subpixel will almost certainly not be in 2.5 - are you saying this and the backend PRs should then also not be labeled as 2.5? — Reply to this email directly, view it on GitHub <#1193 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A3KLECMVUT3NZAH73754YULYAK3U7AVCNFSM6AAAAAA5VWTZXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGE3DMMRVGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[caseyflex]

The issue is wanting a unified treatment of PEC across all three cases: ordinary, anisotropic, and 2D. On Fri, Oct 20, 2023 at 7:01 PM Charles Wojcik ***@***.***> wrote:

…

Weiliang had a proposal on the backend PR that could be implemented before PEC subpixel as far as I am aware. I haven’t looked into implementing it yet. On Fri, Oct 20, 2023 at 6:58 PM momchil-flex ***@***.***> wrote: > PEC subpixel will almost certainly not be in 2.5 - are you saying this > and the backend PRs should then also not be labeled as 2.5? > > — > Reply to this email directly, view it on GitHub > <#1193 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/A3KLECMVUT3NZAH73754YULYAK3U7AVCNFSM6AAAAAA5VWTZXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGE3DMMRVGE> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

[caseyflex]

@weiliangjin2021 do you want to change the meshing to use the relevant component even when another component is PEC?

[weiliangjin2021]

@weiliangjin2021 do you want to change the meshing to use the relevant component even when another component is PEC?

Could you edit is_comp_pec method in Medium2D, and push the changes directly? @caseyflex

[weiliangjin2021]

One caveat in scene visualization is that only an isotropic PEC will be plotted as PEC. An anisotropic medium where some components are PEC is plotted as regular medium. Do you think it's fine @tylerflex ?

[caseyflex]

@weiliangjin2021 do you want to change the meshing to use the relevant component even when another component is PEC?

Could you edit is_comp_pec method in Medium2D, and push the changes directly? @caseyflex

It seems like is_comp_pec should only be a method in AnisotropicMedium, since it doesn't make sense for an arbitrary AbstractMedium. Then, we can have is_comp_pec in Medium2D as well, but in addition to taking the component axis, it can take the normal axis, which is known in the mesher. This would be required to map ss, tt to xx, yy, zz.

[shashwat-sh]

This makes sense to me. About the plotting, I think the current behaviour of only plotting isotropic PEC as PEC makes sense, since the anisotropic case with some PEC components seems to be a fairly special case, and probably used in a very different context.

[caseyflex]

@weiliangjin2021 , I pushed the changes we discussed. Also, I changed it to plot as PEC if any component is PEC, rather than if all components are PEC. Please check if this new handling makes sense.

[weiliangjin2021]

One last comment. Otherwise all look good to me.

[caseyflex]

One last comment. Otherwise all look good to me.

thanks for the catch. This should be ready, maybe we want to squash the commits though.

[weiliangjin2021]

One last comment. Otherwise all look good to me.

thanks for the catch. This should be ready, maybe we want to squash the commits though.

Thanks, I'll take care of that. Usually we squash just before the merge so that changes can be better monitored.

[momchil-flex]

So is there anything left to do @weiliangjin2021 ?

[weiliangjin2021]

So is there anything left to do @weiliangjin2021 ?

just start to squash and merge.