Fix updater for hdf5 files with custom data, and add hdf5 files to automatic updater testing #1200
Conversation
momchil-flex
force-pushed
the
momchil/hdf5_updater
branch
from
b2b2fcf
to
851f5e7
Compare
| @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ### Fixed | |||
| - Properly handle `.freqs` in `output_monitors` of adjoint plugin. | |||
| - Simulation updater for `.hdf5` files with custom data. | |||
There was a problem hiding this comment.
custom source more specifically? I thought the existing one seemed to work with custom medium?
There was a problem hiding this comment.
I only tried custom source and custom medium and yeah for some reason custom medium seemed fine. However I haven't tried other custom data, so not sure. Also not sure if there's a way to create the custom medium in which it will error (e.g. passing an xarray object as opposed to one of our inherited ones?) So maybe safer to leave as is?
tests/test_components/test_IO.py
Outdated
| @@ -187,7 +192,10 @@ def test_validation_speed(tmp_path): | |||
| @pytest.mark.parametrize("sim_file", SIM_FILES) | |||
| def test_simulation_updater(sim_file): | |||
| """Test that all simulations in ``SIM_DIR`` can be updated to current version and loaded.""" | |||
| sim_updated = td.Simulation.from_file(sim_file) | |||
| if sim_file[-2:] == "h5": | |||
There was a problem hiding this comment.
we could also consider just changing from_file to handle .h5 by adding it here:
https://github.com/flexcompute/tidy3d/blob/develop/tidy3d/components/base.py#L223-L228
probably better while we're at it.
There was a problem hiding this comment.
Updated, have a quick look?
…tomatic updater testing
momchil-flex
force-pushed
the
momchil/hdf5_updater
branch
from
851f5e7
to
f400a43
Compare
No description provided.