handle case with no adjoint sources #1218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick and dirty way of fixing things, but it should work. If no adjoint sources detected:
This assumes that the simulation will still run if the only source has an amplitude of 0. @momchil-flex do you know? If there was some auto-detection of this case (or when no sources are present) that returned zero'd out data that could be another way to handle things.
Main downside of this is that it charges a useless simulation to the user, but I think to do this properly would require a lot of construction, so I wanted to throw this out there to discuss as a medium-short term fix to this relatively uncommon edge case.
I also am not sure how to set a reliably small run_time. Maybe something >0 but small like 1e-20 would be another approach?
#1217