Error instead of warning for zero-dim boundaries not periodic or Bloch #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashwat-sh
force-pushed
the
shash/zero_dim_pml_error
branch
2 times, most recently
from
e4f9518
to
5be7616
Compare
momchil-flex
approved these changes
Oct 30, 2023
CHANGELOG.md
Outdated
| @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Update versions of `boto3`, `requests`, and `click`. | |||
| - python 3.7 no longer tested nor supported. | |||
| - Remove warning that monitors now have `colocate=True` by default. | |||
| - If `PML` or any absorbing boundary condition is used along a direction where the `Simulation` size is zero, and error will be raised, rather than just a warning. | |||
- update changelog
momchil-flex
force-pushed
the
shash/zero_dim_pml_error
branch
from
5be7616
to
9dde741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.