Truncate circular filter in edge case #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
force-pushed
the
tyler/fix/adjoint/filter/shapes
branch
from
2653525
to
b83cf65
Compare
tylerflex
changed the title
tylerflex
force-pushed
the
tyler/fix/adjoint/filter/shapes
branch
3 times, most recently
from
9d714d9
to
277e4aa
Compare
tylerflex
force-pushed
the
tyler/fix/adjoint/filter/shapes
branch
from
277e4aa
to
b6ce8cb
Compare
e-g-melo
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the filter radius was larger than the input array (in pixels) along any dimension, scipy raised an error.
Now, we log a warning and truncate the kernel along that dimension to match the input shape (note that the kernel is odd, so it might be 1 smaller if the input shape is even)
I also added a switch if we want to instead raise, maybe this is unnecessary.