adds SimulationData.mnt_data_from_file() method to load individual MonitorData
#1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
force-pushed
the
tyler/mnt_load
branch
from
bf38d92
to
3514eef
Compare
tylerflex
force-pushed
the
tyler/mnt_load
branch
from
3514eef
to
370eb2e
Compare
shashwat-sh
approved these changes
Nov 13, 2023
tidy3d/components/data/sim_data.py
Outdated
| @@ -369,6 +376,65 @@ def get_intensity(self, field_monitor_name: str) -> xr.DataArray: | |||
| field_monitor_name=field_monitor_name, field_name="E", val="abs^2" | |||
| ) | |||
|
|
|||
| @classmethod | |||
| def mnt_data_from_file(cls, fname: str, mnt_name: str, **parse_obj_kwargs) -> MonitorDataType: | |||
| """Loads a monitor data from .hdf5, or .hdf5.gz file. | |||
There was a problem hiding this comment.
The check below (line 404) does not seem to allow .hdf5.gz. Does pathlib.Path(fname) internally extract .gz files?
There was a problem hiding this comment.
oh right, no the pathlib.path just is to check the extension but I'll make the docstring clearer that it only works for hdf5.
There was a problem hiding this comment.
I guess if we start gzipping simulation data files, we should still unzip them right after download.
There was a problem hiding this comment.
yea, it seems like a bit of a complication to do the unzipping in this function, would need to specify another path for the new file I think. might be possible to do it through a temporary file but perhaps it's too complicated for this application.
tylerflex
force-pushed
the
tyler/mnt_load
branch
from
370eb2e
to
e5e1c5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax:
loads a monitor data from a subgroup in the
SimulationDatafile.JSON_STRINGto get the monitor type info.MonitorDataTypeMonitorData.from_file()with a constructed group path to do the loading.Some error checking thrown in, only works with
.hdf5files at the moment.