Fix for 2D PEC #1256
Merged
Fix for 2D PEC #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiliangjin2021
approved these changes
Nov 18, 2023
| @@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - When writing the json string of a model to an `hdf5` file, the string is split into chunks if it has more than a set (very large) number of characters. This fixes potential error if the string size is more than 4GB. | |||
| - Proper equality checking between `Tidy3dBaseModel` instances, which takes `DataArray` values and coords into account and handles `np.ndarray` types. | |||
| - Correctly set the contour length scale when exporting 2D (or 1D) structures with custom medium to GDSII. | |||
| - Fixed a couple bugs in the handling of 2D PEC materials. | |||
There was a problem hiding this comment.
2D PEC is unreleased, so no need to add it here?
There was a problem hiding this comment.
Good point, changelog must be causal!
caseyflex
approved these changes
Nov 20, 2023
momchil-flex
force-pushed
the
shash/fix_pec2d
branch
from
1471857
to
5429400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.