Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump jax and jaxlib versions to 0.4.* #1326

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

tylerflex
Copy link
Collaborator

@tylerflex tylerflex commented Dec 19, 2023

@daquinteroflex note: when we merge this, we should also update it in the docs refractor.

@daquinteroflex
Copy link
Collaborator

Sounds good! Just for reference on the caret spec, it's not implemented with pip, but the equivalent definition is here if it helps

Copy link
Collaborator

@daquinteroflex daquinteroflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable! Never done a "proper" review so let me know any guidance, other than a "generally looks reasonable".

@tylerflex
Copy link
Collaborator Author

for this one, more of just a sanity check yea. But in the future, we will go through the changed files, make comments and suggestions, and then suggest a few changes (if necessary). similar to what I did reviewing your docs PR.

@tylerflex tylerflex merged commit 1919e90 into develop Dec 20, 2023
14 checks passed
@tylerflex tylerflex deleted the tyler/adjoint/bump_jax_0_4 branch December 20, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants