Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further docs improvements and full spellcheck #1340

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

daquinteroflex
Copy link
Collaborator

@daquinteroflex daquinteroflex commented Dec 27, 2023

  • Emoji drop
  • m2r2 conversion.
  • Full spellcheck of the repository

@daquinteroflex
Copy link
Collaborator Author

I think ruff screwed up some tests

@daquinteroflex daquinteroflex added rc1 1st pre-release 2.6 labels Jan 2, 2024
@daquinteroflex daquinteroflex marked this pull request as ready for review January 2, 2024 16:16
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daquinteroflex !
There were a lot of typos :D. Also will be fun to have all of these emojis.

About the m2r2, do we need to automatically convert the markdown files to readme every time we change the readme? or how will that work?

CHANGELOG.md Outdated Show resolved Hide resolved
@daquinteroflex
Copy link
Collaborator Author

Whoops so any remaining rst converted files are left as a mistake. m2r2 should be working as before with .. mdinclude which was what I was working on to make compatible with sphinx6 and most relevant features are converted (not all but I can implement as necessary little by little).

I will remove the generated rst files and fix the error you mention above and rebase then.

@daquinteroflex daquinteroflex merged commit 996ec08 into pre/2.6 Jan 3, 2024
12 checks passed
@daquinteroflex daquinteroflex deleted the dario/further_docs_improvements branch January 3, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rc1 1st pre-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants